remove check_storage_aliases #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mruberry
reviewed
Nov 19, 2024
jjsjann123
changed the title
|
failing tests seems to be coming from nvfuser. |
jjsjann123
commented
Dec 1, 2024
jjsjann123
changed the title
|
@jjsjann123 Is this ready for a review now? |
Yes. Since this is only removing code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation is to remove the use of
numelin code logic, since number of elements doesn't play well with dynamic shape yet.I don't know what
check_storage_aliasesis protecting us against. So I removed the whole thing and looks like we don't have any test validating the logic neither.This is a follow up on conversation here: https://github.com/Lightning-AI/lightning-thunder/pull/877/files#r1844732984
cc'ing @crcrpar for visibility.